Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC: Show Awesome Motive plugins when ref param is present #95307

Draft
wants to merge 16 commits into
base: trunk
Choose a base branch
from
Draft

POC: Show Awesome Motive plugins when ref param is present #95307

wants to merge 16 commits into from
+107 −11

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Oct 11, 2024 •
edited
Loading

Related to #

Proposed Changes

  • This replaces the Paid plugins section with Awesome Motive plugins if a ref param is present

Why are these changes being made?

  • This is needed for peRNfl-14g-p2

Testing Instructions

  • Log in
  • Go to /plugins/{SITED_ID}?ref=awesome-motive-lp
  • You should see the feature plugins on top, similar to the first results of searching for developer: Awesome Motive
Screenshot 2024-10-11 at 10 58 07

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@claudiucelfilip claudiucelfilip self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122680
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122680&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-122680&env=a8c-for-agencies

@claudiucelfilip claudiucelfilip marked this pull request as draft October 11, 2024 07:55
@matticbot
Copy link
Contributor

matticbot commented Oct 11, 2024 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1181 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                              +1237 B  (+0.0%)     +482 B  (+0.1%)
jetpack-cloud-plugin-management      +1237 B  (+0.1%)     +482 B  (+0.1%)
marketplace                           +902 B  (+0.1%)     +396 B  (+0.1%)
theme                                 +565 B  (+0.1%)     +284 B  (+0.1%)
jetpack-cloud-agency-sites-v2         +565 B  (+0.0%)     +295 B  (+0.1%)
a8c-for-agencies-sites                +565 B  (+0.0%)     +295 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~276 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-design-playground       +565 B  (+0.0%)     +276 B  (+0.1%)
async-load-design                  +565 B  (+0.0%)     +276 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip claudiucelfilip force-pushed the add/awesome-motive-plugins-landing branch 4 times, most recently from 1fb8e92 to f0be948 Compare October 22, 2024 13:28
@matticbot
Copy link
Contributor

matticbot commented Oct 22, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/awesome-motive-plugins-landing on your sandbox.

@claudiucelfilip claudiucelfilip force-pushed the add/awesome-motive-plugins-landing branch from 33c145a to 43e710c Compare October 24, 2024 05:47
@claudiucelfilip claudiucelfilip force-pushed the add/awesome-motive-plugins-landing branch from 43e710c to f462656 Compare October 24, 2024 10:49
@claudiucelfilip claudiucelfilip force-pushed the add/awesome-motive-plugins-landing branch from d458cd8 to 7786290 Compare October 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiucelfilip @matticbot